Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Add deprecation for view helper #11389

Merged
merged 1 commit into from
Jun 9, 2015

Conversation

bantic
Copy link
Member

@bantic bantic commented Jun 9, 2015

There are many tests in the test suite that use the view helper ({{view 'someview'}}). In addition to adding the deprecation for this usage, this PR unsets RAISE_ON_DEPRECATION for the ember codebase. This allows the test suite to continue to pass for now until we have time to rewrite those tests to use components instead.

It also changes some tests in ember-debug that presumed that RAISE_ON_DEPRECATION would always be true.

  • change env value RAISE_ON_DEPRECATION to false
  • change tests for Ember.deprecate that relied on RAISE_ON_DEPRECATION being true

refs #11377

  * change env value RAISE_ON_DEPRECATION to false
  * change tests for Ember.deprecate that relied on RAISE_ON_DEPRECATION being true

refs emberjs#11377
@bantic
Copy link
Member Author

bantic commented Jun 9, 2015

The deprecation links to the Deprecation page in the ember guides (PR there: emberjs/website#2195).

@mixonic
Copy link
Member

mixonic commented Jun 9, 2015

@rwjblue we would appreciate a 👍 from you here.

rwjblue added a commit that referenced this pull request Jun 9, 2015
[BUGFIX beta] Add deprecation for view helper
@rwjblue rwjblue merged commit c471c0f into emberjs:master Jun 9, 2015
@bantic bantic deleted the deprecate-view-helper branch June 10, 2015 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants